use the new function fails_with_code #7371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
force-pushed
the
use-new-function
branch
2 times, most recently
from
d68c9ac to
01b51b9
Compare
sylvestre
changed the title
sylvestre
force-pushed
the
use-new-function
branch
2 times, most recently
from
877b555 to
b2697dd
Compare
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
use-new-function
branch
from
b2697dd to
2bf6195
Compare
RenjiSann
requested changes
Mar 1, 2025
tests/by-util/test_chmod.rs
Outdated
Comment on lines
446
to
445
| .no_stderr() | ||
| .code_is(1); | ||
| .no_stderr(); |
There was a problem hiding this comment.
Here fails() was not changed to fail_with_code().
tests/by-util/test_chroot.rs
Outdated
| @@ -160,7 +159,7 @@ fn test_preference_of_userspec() { | |||
| .arg("--groups") | |||
| .arg("ABC,DEF") | |||
| .arg(format!("--userspec={username}:{group_name}")) | |||
| .fails(); | |||
| .fails_with_code(125); | |||
|
|
|||
| result.code_is(125); | |||
There was a problem hiding this comment.
Should remove this line ?
There was a problem hiding this comment.
yeah, missed this pattern!
tests/by-util/test_cksum.rs
Outdated
Comment on lines
438
to
440
| .fails() | ||
| .no_stdout() | ||
| .stderr_contains("cksum: the --raw option is not supported with multiple files") | ||
| .code_is(1); | ||
| .stderr_contains("cksum: the --raw option is not supported with multiple files"); |
|
GNU testsuite comparison: |
Done with ``` $ perl -0777 -i -pe 's/([ \t]+)\.fails\(\)[ \t]*\n[ \t]+\.no_stdout\(\)[ \t]*\n[ \t]+\.code_is\(([0-9]+)\);/\1.fails_with_code(\2)\n\1.no_stdout();/gs' *rs $ sed -i -e "s|.fails()(.*).code_is(|.fails_with_code(|g" *rs $ perl -0777 -i -pe 's/([ \t]+)\.fails\(\)[ \t]*\n[ \t]+\.code_is\(([0-9]+)\);/\1.fails_with_code(\2);/gs' *rs $ perl -0777 -i -pe 's/([ \t]+)\.fails\(\)(.*?)[ \t]+\.code_is\(([0-9]+)\);/\1.fails_with_code(\3)\2;/gs' *rs ... ```
sylvestre
force-pushed
the
use-new-function
branch
from
2bf6195 to
18cb7dc
Compare
RenjiSann
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done with