Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: fix/disable warnings introduced with Rust 1.85 #7329

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Feb 21, 2025

This PR fixes a clippy warning from the precedence lint and disables warnings from the unnecessary_map_or lint. Those warnings are disabled instead of fixed because the fix requires a MSRV of 1.82.

@cakebaker cakebaker marked this pull request as draft February 21, 2025 06:38
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

because fix requires an MSRV of 1.82
@cakebaker cakebaker force-pushed the clippy_fix_warnings_rust_1_85 branch from 3576999 to 9074f3f Compare February 21, 2025 06:55
@cakebaker cakebaker marked this pull request as ready for review February 21, 2025 06:59
@cakebaker cakebaker changed the title clippy: fix warnings introduced with Rust 1.85 clippy: fix/disable warnings introduced with Rust 1.85 Feb 21, 2025
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit d065e17 into uutils:main Feb 21, 2025
65 checks passed
@cakebaker cakebaker deleted the clippy_fix_warnings_rust_1_85 branch February 21, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants