Improve fuzzer logging #7281
Improve fuzzer logging #7281
Conversation
RenjiSann
force-pushed
the
renji/improve-fuzzer-log
branch
from
e63f6e9 to
910c67a
Compare
|
GNU testsuite comparison: |
|
Seems that you have unrelated changes in your pr |
|
Indeed, I pushed my dev environment :') |
|
it looks great :) |
RenjiSann
force-pushed
the
renji/improve-fuzzer-log
branch
2 times, most recently
from
d07797e to
046af8f
Compare
RenjiSann
force-pushed
the
renji/improve-fuzzer-log
branch
from
046af8f to
e94e077
Compare
|
GNU testsuite comparison: |
|
@sylvestre I'll let you merge if you're happy with the changes ! |
|
sorry, i didn't noticed that you cleaned it |
fuzz/fuzz_targets/fuzz_cksum.rs
Outdated
| }; | ||
| use rand::Rng; | ||
| use std::env::temp_dir; | ||
| use std::fs::{self, File}; | ||
| use std::io::Write; | ||
| use std::process::Command; | ||
|
|
||
| static CMD_PATH: &str = "cksum"; | ||
| static CMD_PATH: &str = "../gnu/src/cksum"; |
There was a problem hiding this comment.
It means that you need gnu + build it
Currently it is using the bin from the system
There was a problem hiding this comment.
On my system, coreutils version is 9.5, so I am missing the recently added crc32b algorithm, which leads to many errors. IMO, it's better to fuzz against the same version of the GNU coreutils as the one we test against, but that's not a strong requirement for me, if it's too much work
There was a problem hiding this comment.
Makes sense but should be done in a different pr
…remove false positives, improve logging
RenjiSann
force-pushed
the
renji/improve-fuzzer-log
branch
from
e94e077 to
6afa515
Compare
|
GNU testsuite comparison: |
While fuzzing, I had a hard time understanding the output, because of the number of tests and the lack of uniformity in the output.
This PR adds colored output to the logging (like for the diffs, for the test result, etc...)
Here is an example (sorry for the accessibility, but a screenshot is the only way to show the colored output)
Note: I have made little modifications to
fuzz_cksumto fix some false positives and to further improve logs' readability, because it's the tool I am the most familiar with.