Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Head: ensure stdin input stream is correct on exit #7253

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Head: ensure stdin input stream is correct on exit #7253

merged 1 commit into from
Feb 28, 2025

Conversation

karlmcdowall
Copy link
Contributor

@karlmcdowall karlmcdowall commented Feb 1, 2025 •
edited
Loading

Head tool now ensures that stdin is set to the last character that was output by the tool. This ensures that if any subsequent tools are run from the same input stream they will start at the correct point in the stream.

These changes should fix the head-pos.sh GNU test. This is tracked by issue #7028.

@karlmcdowall karlmcdowall marked this pull request as draft February 1, 2025 23:36
@karlmcdowall karlmcdowall mentioned this pull request Feb 1, 2025
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/head/head-pos is no longer failing!
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@karlmcdowall
Copy link
Contributor Author

Will un-bork the non-unix build and post an update...

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/head/head-pos is no longer failing!
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

GNU testsuite comparison:

GNU test failed: tests/head/head. tests/head/head is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/head/head-pos is no longer failing!

@karlmcdowall karlmcdowall force-pushed the head_stdio_file branch 2 times, most recently from f48b315 to 3cd59f0 Compare February 5, 2025 03:29
@karlmcdowall karlmcdowall marked this pull request as ready for review February 5, 2025 03:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/head/head-pos is no longer failing!

jfinkels
jfinkels reviewed Feb 6, 2025
View reviewed changes
@jfinkels jfinkels linked an issue Feb 6, 2025 that may be closed by this pull request
head: fails to leave remaining bytes of file available for subsequent commands #7028
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/head/head-pos is no longer failing!

@karlmcdowall karlmcdowall mentioned this pull request Feb 12, 2025
Merged
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/head/head-pos is no longer failing!
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@karlmcdowall karlmcdowall marked this pull request as draft February 20, 2025 16:14
@karlmcdowall karlmcdowall force-pushed the head_stdio_file branch 3 times, most recently from e09cc93 to bfccf75 Compare February 20, 2025 16:34
@karlmcdowall karlmcdowall marked this pull request as ready for review February 20, 2025 16:35
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/head/head-pos is no longer failing!
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/head/head-pos is no longer failing!
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/head/head-pos is no longer failing!
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

jfinkels
jfinkels reviewed Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@jfinkels jfinkels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself makes sense, I just have a question about the tests

@karlmcdowall
Head: ensure stdin input stream is correct on exit
ad20cb3 
Fix issue uutils#7028
Head tool now ensures that stdin is set to the last character
that was output by the tool. This ensures that if any subsequent
tools are run from the same input stream they will start at the
correct point in the stream.
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/head/head-pos is no longer failing!
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@RenjiSann RenjiSann merged commit 76ad604 into uutils:main Feb 28, 2025
65 checks passed
@RenjiSann
Copy link
Collaborator

Thank you for your contribution ! 🥳

@moonfruit moonfruit mentioned this pull request Mar 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfinkels jfinkels jfinkels left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

head: fails to leave remaining bytes of file available for subsequent commands
3 participants
@karlmcdowall @RenjiSann @jfinkels