Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rand_pcg #7233

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Remove rand_pcg #7233

merged 2 commits into from
Jan 28, 2025

Conversation

cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Jan 28, 2025 •
edited
Loading

I noticed that the rand_pcg crate is only used in one single place in a sort test. This PR removes the crate and uses rand::rngs::SmallRng::seed_from_u64 instead of rand_pcg::Pcg32::seed_from_u64.

Edit: The crate was added in #3927

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit dbfdff1 into uutils:main Jan 28, 2025
64 of 65 checks passed
@cakebaker cakebaker deleted the remove_rand_pcg branch January 28, 2025 12:33
@moonfruit moonfruit mentioned this pull request Mar 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre