Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort: options -C and -c should be mutually exclusive but aren't #7191

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

ic3man5
Copy link
Contributor

@ic3man5 ic3man5 commented Jan 22, 2025

Fixes #7184 :

$ cargo run sort -Cc
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/coreutils sort -Cc`
error: the argument '--check-silent' cannot be used with '--check[=<check>...]'

Usage: target/debug/coreutils sort [OPTION]... [FILE]...

For more information, try '--help'.
$ echo $?
2

GNU sort:

$ sort -Cc
sort: options '-cC' are incompatible
$ echo $?
2

Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/usage_vs_getopt. tests/misc/usage_vs_getopt is passing on 'main'. Maybe you have to rebase?

@sylvestre
Copy link
Contributor

sylvestre commented Jan 22, 2025

Could you please add a test to make sure we don't regress in the future? thanks

@ic3man5
Copy link
Contributor Author

ic3man5 commented Jan 23, 2025

Could you please add a test to make sure we don't regress in the future? thanks

done

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 6c8ec89 into uutils:main Jan 23, 2025
65 checks passed
@cakebaker
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort: options -C and -c should be mutually exclusive but aren't
3 participants