install: with -t, check if we aren't passed a file #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
install-basic
branch
from
41023fc to
28b1de6
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 21, 2023
cakebaker
reviewed
Dec 21, 2023
There was a problem hiding this comment.
There is one situation not handled by this solution: if the target ends with a slash. With GNU, install -t sub/b -Dv a and install -t sub/b/ -Dv a both lead to the same error. With uutils, install -t sub/b/ -Dv a shows a "creating directory" message followed by a "failed to create" message.
There was a problem hiding this comment.
I feel that it is a different problem in this case, no ?
There was a problem hiding this comment.
Yes, though it is related. We can fix it in another PR.
Should pass tests/install/basic-1
sylvestre
force-pushed
the
install-basic
branch
from
28b1de6 to
9ca7c3e
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should pass tests/install/basic-1