-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
join: remove crash! macro #5540
Conversation
GNU testsuite comparison:
|
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think you're on the right track and the solution is correct, but I do have a suggestion to make it a bit more like the other utils (and not having to use the UnorderedInput
variant).
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! This is exactly what I had in mind. Because we now use UResult
I think we can also remove this bit:
and just make that a call to exec
and return the result. And then we can merge this.
Awesome, thanks 😄 Let me know if this is what you had in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's it! I'll wait for the CI but seems ready to be merged. Thanks!
Thanks! |
This is related to issue #5487. Removes the
crash!
macro from join.