BOOLNULL to Atom type & INT 64 bits #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal contains 2 changes:
introduce the ATOM type instead BOOLNULL as for Convert NULLBOOL type to ATOM type bipf-spec#3 but with 64bit uint and "trimmed" encoding of int introduced by tinySSB. This does not require current implementation to be modified if they do not want to benefit from this extension of meaning.
specify that INT val is a 64 bits signed integer . Note that today implementations of tinySSB are using 32 bits int. This change do not require them to be modified immediately. And modification if straightforward. Meanwhile I think it is important to make the format more future proof. As it is used in SSB for the timestamp encoding, we are subject to the 2038 Problem https://en.wikipedia.org/wiki/Year_2038_problem#:~:text=Consequently%2C%20if%20a%20signed%2032,on%20Tuesday%2C%2019%20January%202038.