[RegistryPreview] Enhanced preview for value data

[htcfreek]

Summary of the Pull Request

Add a button to the data grid that shows a windows for complex value preview.

Screenshots

Button

Preview: REG_SZ

Preview: REG_MULTI_SZ

Preview: REG_EXPAND_SZ

Preview: REG_DWORD and REG_QWORD

Preview: REG_BINARY

PR Checklist

• Closes: [Registry Preview] Enhanced preview windows for value data #36877
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized => missing yet
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[htcfreek]

@jaimecbernardo , @crutkas
I copied the code of HexBox control into our sources.

1. Before I continue to fix all build and style errors, is this the correct way to go?
2. What changes are required in Notice.md?
3. Do we need an attribution on the Settings page?

[jaimecbernardo]

@jaimecbernardo , @crutkas I copied the code of HexBox control into our sources.

1. Before I continue to fix all build and style errors, is this the correct way to go?
2. What changes are required in Notice.md?
3. Do we need an attribution on the Settings page?

@htcfreek , sounds good like a good approach.

1. Instead of fixing the build (I suppose analyzer) and style errors, it might make more sense to have them as exceptions, in order to keep the code similar to upstream. That will make updating easier. For styling, the .pipelines\applyXamlStyling.ps1 file can be changed to exclude files from that directory and for analyzers I suspect we can do the same in "src\codeAnalysis\GlobalSuppressions.cs" similar to what's done there for MouseWithoutBorders.

2 and 3. I think Notice.md would be sufficient, similar to what we do for "The Quite OK Image Format reference decoder". No need for attribution on the Settings page. Mentioning @cinnamon-msft , in case there's something else that needs to be done to attribute.

[htcfreek]

@jaimecbernardo
For 1: But doesn't this require to keep the original namespace? How show we implement it then? Or is changing the namespace okay?

[jaimecbernardo]

@htcfreek , I didn't quite understand what you meant. I guess idea would be to keep it as similar as possible to the original code 🤔 But if changes are required to make it work, it makes sense to make those changes.

[htcfreek]

for analyzers I suspect we can do the same in "src\codeAnalysis\GlobalSuppressions.cs"

@jaimecbernardo
Do we need each of the 100+ error in a single definition or can we configure something like supress all for namespace x?

[jaimecbernardo]

for analyzers I suspect we can do the same in "src\codeAnalysis\GlobalSuppressions.cs"

@jaimecbernardo Do we need each of the 100+ error in a single definition or can we configure something like supress all for namespace x?

@htcfreek Ouch, I think the suppression needs to be for category of errors, not single errors. We shouldn't be getting 100+ different category of errors, right? Even for MouseWithoutBorders 5 supressions were enough for all the code analysis errors we were getting there.

[jaimecbernardo]

For spellcheck ignoring, it's possible to set the path in ".github\actions\spell-check\excludes.txt" as well

[htcfreek]

@jaimecbernardo
The control's code is ported now.

But the control isn't working. It looks like the Build is ignoring the Generic.xaml file. Can you please take a look.

[htcfreek]

We can't update to 3.* branch as it breaks the code.