Ubuntu 22.04 #1716
Ubuntu 22.04 #1716
Conversation
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
packages starting debugging process with tests Signed-off-by: Nicholas Massad <[email protected]>
Signed-off-by: Nicholas Massad <[email protected]>
| 'indy_vdr==0.4.2', | ||
| 'aries-askar==0.4.3', | ||
| 'indy-credx==1.1.1' |
There was a problem hiding this comment.
This makes the indy-plenum deployment package dependent on client side components that are only used for tests.
Signed-off-by: Nicholas Massad <[email protected]>
Signed-off-by: Nicholas Massad <[email protected]>
Signed-off-by: Wade Barnes <[email protected]>
Signed-off-by: MoulayHicham <[email protected]>
…uilding functions from async to sync to align with indy-vdr API Signed-off-by: MoulayHicham <[email protected]>
lol, I see you noticed. Thanks |
|
@WadeBarnes I've addressed your comment regarding duplication in the request parsing/conversion by creating a helper function called convert_indy_vdr_request_to_plenum(). I'll include this in my next push. |
…_audit_ledger_multiple_ledgers_in_one_batch.py into a helper function for better maintainability Signed-off-by: MoulayHicham <[email protected]>
|
Tests are still having issues with |
setup.py
Outdated
| @@ -99,7 +99,7 @@ def run(self): | |||
| 'base58', | |||
| # pinned because issue with fpm from v4.0.0 | |||
| 'importlib_metadata==3.10.1', | |||
| # 'ioflo==2.0.2', | |||
| 'ioflo==2.0.3', | |||
There was a problem hiding this comment.
This will work, in that the expected version of ioflo will be installed, however ioflo is a dev/test dependency and not a runtime dependency. Therefore it should not be defined here. It should be defined in the tests_require section starting on line 30.
|
DCO sign-off was not included in the most recent commit. @rhofirAtos, please amend your latest commit with DCO sign-off. |
Signed-off-by: MoulayHicham <[email protected]>
Signed-off-by: MoulayHicham <[email protected]>
Signed-off-by: GuillaumeBourque-QC <[email protected]>
…enum-bougui into ubuntu-22.04
Signed-off-by: GuillaumeBourque-QC <[email protected]>
Signed-off-by: MoulayHicham <[email protected]>
Signed-off-by: MoulayHicham <[email protected]>
- Update sdk_send_signed_requests to return coroutines instead of futures - Add explicit coroutine to future conversion in sdk_sign_and_send_prepared_request - Improve flexibility in async operation handling for test framework Signed-off-by: MoulayHicham <[email protected]>
Signed-off-by: GuillaumeBourque-QC <[email protected]>
…enum-bougui into ubuntu-22.04
- Remove .as_dict call since request is already a dictionary - Update error handling to support both RequestRejectedException and CommonSdkIOException - Add support for VdrErrorCode 31 in error message Signed-off-by: MoulayHicham <[email protected]>
| # Need to move libursa.so to parent dir | ||
| && mv /usr/lib/ursa/* /usr/lib && rm -rf /usr/lib/ursa | ||
|
|
||
| RUN pip3 install -U \ | ||
| # Required by newer verion of python | ||
| ioflo==2.0.3 \ |
There was a problem hiding this comment.
This should be unnecessary. ioflo should be installed as a dev dependency when plenum is installed in teh dev container by "postCreateCommand": "pip install .[tests]", in the devcontainer.json file.
Signed-off-by: Nicholas Massad <[email protected]>
…/indy-plenum-bougui into ubuntu-22.04 Signed-off-by: Nicholas Massad <[email protected]>
Modified all tests to no longer require on indy-sdk. Started from where Adam left off. Please correct any changes where I am using wrong inputs/outputs