Bug: E2E test failure with new namespace #1615
Conversation
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
actions/upload-artifact and actions/download-artifact have been deprecated and need updated. https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Fix CVE-2024-45338 and update Postgres
Signed-off-by: Angelina <[email protected]>
|
Thanks for raising this! |
|
|
||
| func Reset() { | ||
| config.RootConfigReset(setDefaults) | ||
| } |
There was a problem hiding this comment.
Make sure to check where this is being used as it is and failing the CI
There was a problem hiding this comment.
Do coreconfig.Reset() and Reset() mean the same this. I noticed the difference in syntax and was not certain if this was a separate function?
There was a problem hiding this comment.
yeah they are the same function. The other file is calling the Reset() that you just deleted in the coreconfig pkg
There was a problem hiding this comment.
Okay so I would need to remove them from there also correct?
There was a problem hiding this comment.
I removed them :). I did remove the additional calls to Reset that were made in additional files as well. I came across internal/events/event_manager_test.go and I noticed there is a line that reads "defer coreconfig.Reset()". I am wondering if the best step is to remove the "defer" keyword? I am still learning GO and from what I understand this word must follow a function or method call. If its not removed would I add this word before "mdi := &databasemocks.Plugin{}" ?
There was a problem hiding this comment.
So defer will run when the function exists. I think we can remove all the places where that old reset API is called and instead rely on the file system reload
There was a problem hiding this comment.
No problem, I will remove the additional lines. Thank you!
Signed-off-by: Angelina <[email protected]>
Signed-off-by: Angelina <[email protected]> Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: Angelina <[email protected]> Signed-off-by: Ry Jones <[email protected]>
|
@aceppaluni I believe you have some merge conflicts from merging main into your branch, can you resolve those please |
|
Hi @EnriqueL8 I am attempting to resolve the conflicts however when I do so, I still seem to have changes inside VS code that are not corrected. Is there a way to correct this? |
|
You should be able to use the resolve editor in VSCode to help you walk through the merge conflicts |
|
If that is too painful as a lot has gone in, you could recreate a new branch at the tip of main and then cherry-pick your commits on top |
|
I can resolve them |
Signed-off-by: Angelina <[email protected]>
|
I resolved them and my Github UI is saying the branch is 19 commits ahead. |
|
Yeah, you need to rebase on top of |
Proposed changes
Removed call to reset and ensured polling to up-to-date. This PR aims to correct issues with e2e failures when adding in namespaces.
Fixes # 1545
Types of changes
Please make sure to follow these points
< issue name >egAdded links in the documentation.Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.