Update github actions to use Node 20 #4641
Merged
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denyeart
commented
Jan 29, 2024
denyeart
commented
- actions/setup-go@v5
- actions/checkout@v4
tock-ibm
previously approved these changes
Jan 29, 2024
- actions/setup-go@v5 - actions/checkout@v4 Need to ensure checkout is done before setup-go for cache to work. Signed-off-by: David Enyeart <[email protected]>
denyeart
force-pushed
the
update_actions
branch
from
a686d62 to
4c8bf50
Compare
pfi79
reviewed
Jan 29, 2024
Comment on lines
+26
to
28
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: ${{ env.GO_VER }} |
There was a problem hiding this comment.
Пожалуйста добавьте к actions/setup-go параметр cache: false
There was a problem hiding this comment.
I switched the order to checkout first and then setup-go to avoid the cache warnings. Is there another reason to disable cache?
There was a problem hiding this comment.
There are no more reasons. The offer is withdrawn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.