Add a fallback pivot strategy when the safe block does not change for a long time #8395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
pivot-block-from-safe-block-fallback-selection
branch
2 times, most recently
from
4a01830 to
081ba85
Compare
fab-10
force-pushed
the
pivot-block-from-safe-block-fallback-selection
branch
from
081ba85 to
e75e22b
Compare
… a long time Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
pivot-block-from-safe-block-fallback-selection
branch
from
e75e22b to
de7a7f4
Compare
marcosio
pushed a commit
to IoBuilders/besu
that referenced
this pull request
Mar 12, 2025
… a long time (hyperledger#8395) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Marcos Serradilla Diez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
If the safe block does not change after 7 minutes, then fallback to a previous head block as pivot.
Selecting a previous head block, instead of the last one, to reduce the possibility to be affected by reorgs.
This fallback is especially useful when the chain does not finalize, like it is happing to Holesky
Fixed Issue(s)
fixes #8393
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests