Chore: Flaky Clique Mining Test #8357
Draft
+81
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Preeti <[email protected]>
Signed-off-by: Preeti <[email protected]>
macfarla
reviewed
Mar 12, 2025
| decreasePeriodTo2_Transition, | ||
| decreasePeriodTo1_Transition, | ||
| dummy_Transition, | ||
| increasePeriodTo2_Transition)); |
There was a problem hiding this comment.
if you run gradlew spotlessApply that will get rid of these whitespace changes
There was a problem hiding this comment.
Thanks! I'll run gradlew spotlessApply to clean up the whitespace.
macfarla
reviewed
Mar 12, 2025
| LOG.info("Proposing removal of minerNode2 and minerNode3..."); | ||
| try { | ||
| minerNode1.execute(cliqueTransactions.createRemoveProposal(minerNode2)); | ||
| minerNode1.execute(cliqueTransactions.createRemoveProposal(minerNode3)); |
There was a problem hiding this comment.
I think removing them rather than stopping the nodes will invalidate this test - miner1 can produce blocks if it is the only validator (ie others have been removed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
fixed #8240
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests