Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] update non-bom dependencies #8315

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Conversation

macfarla
Copy link
Contributor

PR description

Update dependencies that don't come in via a bom

Not updated (unsure why but updating these introduces failures in checkLicense target):

    api 'org.springframework.security:spring-security-crypto:6.3.3'
    api 'org.springframework.security:spring-security-crypto:6.4.2'

    api 'org.wiremock:wiremock:3.9.1'
    api 'org.wiremock:wiremock:3.12.0'

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla marked this pull request as draft February 17, 2025 07:55
@macfarla
Copy link
Contributor Author

think the antlr upgrade is causing these test failures - need to look into it

> Task :besu:test

PrivacyOptionsTest > privacyTlsOptionsRequiresPrivacyToBeEnabledToml() FAILED
    java.lang.AssertionError at PrivacyOptionsTest.java:125

ProfilesTest > Valid Profile with overrides does not error > 1 - Profile Name override: dev FAILED
    java.lang.AssertionError at ProfilesTest.java:89

BesuCommandTest > callingWithNoBootnodesConfig() FAILED
    java.lang.AssertionError at BesuCommandTest.java:358

JsonRpcHttpOptionsTest > rpcHttpTlsRequiresRpcHttpEnabledToml() FAILED
    java.lang.AssertionError at JsonRpcHttpOptionsTest.java:253

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla marked this pull request as ready for review February 17, 2025 10:42
@fab-10
Copy link
Contributor

fab-10 commented Feb 17, 2025

ANTLR is somewhat tricky to update, since some deps require a specific version, about the license issue, try updating the plugin first and if not working yet we need to check the details of the failure

@macfarla macfarla enabled auto-merge (squash) February 17, 2025 21:34
@macfarla macfarla merged commit 5304006 into hyperledger:main Feb 17, 2025
43 checks passed
@macfarla macfarla deleted the moar-deps branch February 25, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants