fix: move midline-flush.c sleep to occur between flush() invocations #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were doing the sleep() invocation between writing to the stdout/err file descriptors rather than between the times we were flushing them. This update divides the time slept by 3 (bringing it to approx 3x what it was before we encountered CI failures), while moving the sleep between the two flush() invocations. It also adds an extra sleep following the second flush() invocation to make sure that the kernel has time to communicate its contents before the subsequent test.
ysndr
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing the sleep() invocation between writing to the stdout/err file descriptors rather than between the times we were flushing them. This update divides the time slept by 3 (bringing it to approx 3x what it was before we encountered CI failures), while moving the sleep between the two flush() invocations.
It also adds an extra sleep following the second flush() invocation to make sure that the kernel has time to communicate its contents before the subsequent test.