fix: expect less of kernel, sleep longer in tests #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed repeated test failures on CI running on aarch64-linux instances: > Failed test tests/100-lines > --- tests/100-lines.log 1970-01-01 00:00:01.000000000 +0000 > +++ /build/tmp.Xnq7ZeMG7J/100-lines.log 2025-01-29 15:07:16.278776269 +0000 > @@ -49,8 +49,8 @@ > line 25 to stdout > line 25 to stderr > line 26 to stdout > -line 26 to stderr > line 27 to stdout > +line 26 to stderr > line 27 to stderr > line 28 to stdout > line 28 to stderr > make: *** [Makefile:137: tests/100-lines/log] Error 1 This occurs when the kernel _actually_ delivers messages out of order to the stdout and stderr file descriptors, which is very much possible for the Linux kernel. There's really no resolution for this apart from lowering our expectations, and this patch roughly triples the time spent sleeping between lines sent to stdout/stderr by changing `sleep 0` to `sleep 0.01`: $ time sleep 0 real 0m0.003s user 0m0.004s sys 0m0.000s $ time sleep 0.01 real 0m0.013s user 0m0.002s sys 0m0.001s
ysndr
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed repeated CI test failures running on aarch64-linux instances:
This occurs when the kernel actually delivers messages out of order to the stdout and stderr file descriptors, which is very much possible for the Linux kernel.
There's really no resolution for this apart from lowering our expectations, and this patch roughly triples the time spent sleeping between lines sent to stdout/stderr by changing
sleep 0tosleep 0.01: