[16.0][FIX] rma_sale: replacements create order lines

[chienandalu]

When the RMA procurement group has a sale set it will propagate to the pickings. This is inconvenient for this operation as when we confirm the customer delivery a new order line will be created with the replaced option which will be set for invoicing.

cc @Tecnativa TT55461

Not sure about the fix though, as it could be argumented that the replacement could be invoiced with a price of 0 or whatever difference the user considers at the moment. In any case,

This is the relevant core code: https://github.com/odoo/odoo/blob/b1d88c20a6cf2a2f283ed04f145cb9e7fc614755/addons/sale_stock/models/stock.py#L85-L117

In the other hand if there were automatic invoicing processes, wrong invoices would be sent to customers, causing confussions...

Opinions? @sbejaoui @pedrobaeza @victoralmau

[sbejaoui]

We had the same issue, but since we use stock_picking_group_by_partner_by_carrier, which replaces sale_id with sale_ids, we bypassed the problem with this workaround: OCA/stock-logistics-workflow#1789.

[chienandalu]

Thank you @sbejaoui we don't use those modules but as I see it's an issue for you as well and not a feature 😅

The only thing I'm worried about is that sale_id is a stored relation to the group_id.sale_id field and I'm not sure if that relation could be reset in the meantime of validating the picking... which I don't think is going to happen but it isn't impossible...