fix: typo (#5166)

Signed-off-by: LesCyber <[email protected]>

Author: LesCyber

core/ledger/kvledger/txmgmt/statedb/statecouchdb/couchdb.go

@@ -239,12 +239,12 @@ func (dbclient *couchDatabase) createDatabaseIfNotExist() error {
 
 	dbInfo, couchDBReturn, err := dbclient.getDatabaseInfo()
 	if err != nil {
-		if couchDBReturn == nil || couchDBReturn.StatusCode != 404 {
+		if couchDBReturn == nil || couchDBReturn.StatusCode != http.StatusNotFound {
 			return err
 		}
 	}
 
-	if dbInfo == nil || couchDBReturn.StatusCode == 404 {
+	if dbInfo == nil || couchDBReturn.StatusCode == http.StatusNotFound {
 		couchdbLogger.Debugf("[%s] Database does not exist.", dbclient.dbName)
 
 		connectURL, err := url.Parse(dbclient.couchInstance.url())
@@ -265,7 +265,7 @@ func (dbclient *couchDatabase) createDatabaseIfNotExist() error {
 			// returned due to a timeout or race condition.
 			// Do a final check to see if the database really got created.
 			dbInfo, couchDBReturn, dbInfoErr := dbclient.getDatabaseInfo()
-			if dbInfoErr != nil || dbInfo == nil || couchDBReturn.StatusCode == 404 {
+			if dbInfoErr != nil || dbInfo == nil || couchDBReturn.StatusCode == http.StatusNotFound {
 				return err
 			}
 		}
@@ -494,7 +494,7 @@ func (dbclient *couchDatabase) dropDatabase() error {
 
 	resp, couchdbReturn, err := dbclient.handleRequest(http.MethodDelete, "DropDatabase", connectURL, nil, "", "", maxRetries, true, nil)
 	defer closeResponseBody(resp)
-	if couchdbReturn != nil && couchdbReturn.StatusCode == 404 {
+	if couchdbReturn != nil && couchdbReturn.StatusCode == http.StatusNotFound {
 		couchdbLogger.Debugf("[%s] Exiting DropDatabase(), database does not exist", dbclient.dbName)
 		return nil
 	}
@@ -721,7 +721,7 @@ func (dbclient *couchDatabase) readDoc(id string) (*couchDoc, string, error) {
 
 	resp, couchDBReturn, err := dbclient.handleRequest(http.MethodGet, "ReadDoc", readURL, nil, "", "", maxRetries, true, &query, id)
 	if err != nil {
-		if couchDBReturn != nil && couchDBReturn.StatusCode == 404 {
+		if couchDBReturn != nil && couchDBReturn.StatusCode == http.StatusNotFound {
 			couchdbLogger.Debugf("[%s] Document not found (404), returning nil value instead of 404 error", dbclient.dbName)
 			// non-existent document should return nil value instead of a 404 error
 			// for details see https://github.com/hyperledger-archives/fabric/issues/936
@@ -972,7 +972,7 @@ func (dbclient *couchDatabase) deleteDoc(id, rev string) error {
 	resp, couchDBReturn, err := dbclient.handleRequestWithRevisionRetry(id, http.MethodDelete, dbName, "DeleteDoc",
 		deleteURL, nil, "", "", maxRetries, true, nil)
 	if err != nil {
-		if couchDBReturn != nil && couchDBReturn.StatusCode == 404 {
+		if couchDBReturn != nil && couchDBReturn.StatusCode == http.StatusNotFound {
 			couchdbLogger.Debugf("[%s] Document not found (404), returning nil value instead of 404 error", dbclient.dbName)
 			// non-existent document should return nil value instead of a 404 error
 			// for details see https://github.com/hyperledger-archives/fabric/issues/936
@@ -1525,7 +1525,7 @@ func (dbclient *couchDatabase) handleRequestWithRevisionRetry(id, method, dbName
 
 		// If there was a 409 conflict error during the save/delete, log it and retry it.
 		// Otherwise, break out of the retry loop
-		if couchDBReturn != nil && couchDBReturn.StatusCode == 409 {
+		if couchDBReturn != nil && couchDBReturn.StatusCode == http.StatusConflict {
 			couchdbLogger.Warningf("CouchDB document revision conflict detected, retrying. Attempt:%v", attempts+1)
 			revisionConflictDetected = true
 		} else {
@@ -1641,9 +1641,9 @@ func (couchInstance *couchInstance) handleRequest(ctx context.Context, method, d
 		}
 
 		// if there is no golang http error and no CouchDB 500 error, then drop out of the retry
-		if errResp == nil && resp != nil && resp.StatusCode < 500 {
+		if errResp == nil && resp != nil && resp.StatusCode < http.StatusInternalServerError {
 			// if this is an error, then populate the couchDBReturn
-			if resp.StatusCode >= 400 {
+			if resp.StatusCode >= http.StatusBadRequest {
 				// Read the response body and close it for next attempt
 				jsonError, err := io.ReadAll(resp.Body)
 				if err != nil {
@@ -1727,7 +1727,7 @@ func (couchInstance *couchInstance) handleRequest(ctx context.Context, method, d
 	// check to see if the status code from couchdb is 400 or higher
 	// response codes 4XX and 500 will be treated as errors -
 	// golang error will be created from the couchDBReturn contents and both will be returned
-	if resp.StatusCode >= 400 {
+	if resp.StatusCode >= http.StatusBadRequest {
 
 		// if the status code is 400 or greater, log and return an error
 		couchdbLogger.Debugf("Error handling CouchDB request. Error:%s,  Status Code:%v,  Reason:%s",

core/ledger/kvledger/txmgmt/statedb/statecouchdb/couchdbutil.go

@@ -90,7 +90,7 @@ func createCouchInstance(config *ledger.CouchDBConfig, metricsProvider metrics.P
 	}
 
 	// return an error if the http return value is not 200
-	if retVal.StatusCode != 200 {
+	if retVal.StatusCode != http.StatusOK {
 		return nil, errors.Errorf("CouchDB connection error, expecting return code of 200, received %v", retVal.StatusCode)
 	}
 

core/ledger/kvledger/txmgmt/statedb/statecouchdb/statecouchdb.go

@@ -10,6 +10,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"net/http"
 	"sort"
 	"sync"
 
@@ -203,7 +204,7 @@ func (provider *VersionedDBProvider) Drop(dbName string) error {
 	metadataDBName := constructMetadataDBName(dbName)
 	couchDBDatabase := couchDatabase{couchInstance: provider.couchInstance, dbName: metadataDBName}
 	_, couchDBReturn, err := couchDBDatabase.getDatabaseInfo()
-	if couchDBReturn != nil && couchDBReturn.StatusCode == 404 {
+	if couchDBReturn != nil && couchDBReturn.StatusCode == http.StatusNotFound {
 		// db does not exist
 		return nil
 	}