Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore:Remove deprecated CLI --Xsnapsync-synchronizer-flat-db-healing-… #8416

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Chore:Remove deprecated CLI --Xsnapsync-synchronizer-flat-db-healing-… #8416

wants to merge 2 commits into from

Conversation

pr9t
Copy link
Contributor

@pr9t pr9t commented Mar 13, 2025

PR description

This PR removes the deprecated CLI option --Xsnapsync-synchronizer-flat-db-healing-enabled from DiffBasedSubStorageOptions.java. This option has been replaced by --Xbonsai-full-flat-db-enabled

Fixed Issue(s)

fixes #8415

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla macfarla added the breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. label Mar 13, 2025
macfarla
macfarla reviewed Mar 14, 2025
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll also need to add a changelog entry - this is a breaking change.
and remove the TODO on line 87/88

also run spotlessApply, it will standardise the import ordering

@pr9t
Copy link
Contributor Author

pr9t commented Mar 14, 2025 •
edited
Loading

Got it! I will update everything and push the changes.

@pr9t pr9t closed this Mar 14, 2025
@pr9t pr9t reopened this Mar 14, 2025
@matkt
Copy link
Contributor

matkt commented Mar 17, 2025

small conflict to fix . The name of the class changed. It's now PathBasedExtraStorageOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Deprecated CLI Option --Xsnapsync-synchronizer-flat-db-healing-enabled
3 participants
@pr9t @matkt @macfarla