7702 refactor, remove CodeDelegationAccount abstraction #8408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors code delegation handling by removing the CodeDelegationAccount abstraction and centralizing delegation logic into helper classes and services. Key changes include:
- Removal of CodeDelegationAccount, MutableCodeDelegationDelegationAccount, and related files.
- Introduction of CodeDelegationHelper and a simplified CodeDelegationService.
- Updates to tests, protocol spec configurations, and transaction processing logic to use the new delegation approach.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| evm/src/main/java/org/hyperledger/besu/evm/operation/InsufficientGasException.java | New exception class for signaling insufficient gas during delegation resolution. |
| evm/src/main/java/org/hyperledger/besu/evm/worldstate/CodeDelegationHelper.java | Introduces helper methods for code delegation resolution. |
| ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/CodeDelegationProcessor.java | Refactored to use WorldUpdater and a newly instantiated CodeDelegationService. |
| evm/src/main/java/org/hyperledger/besu/evm/operation/AbstractCallOperation.java | Updates to delegate code resolution, integrating the new helper methods and exception handling. |
| Other files | Removal of legacy code delegation account abstractions and adjustments in tests and transaction processing. |
Comments suppressed due to low confidence (1)
evm/src/main/java/org/hyperledger/besu/evm/operation/AbstractCallOperation.java:264
- Consider replacing RuntimeException with a more specific exception type to clearly indicate the missing target account condition and improve downstream error handling.
throw new RuntimeException("A delegated code account must have a target account");
daniellehrner
force-pushed
the
feat/issue-8392/remove_code_delegation_abstraction
branch
from
59486ff to
5f2eb7a
Compare
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
daniellehrner
force-pushed
the
feat/issue-8392/remove_code_delegation_abstraction
branch
from
f8b0f59 to
b7304b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Removes the CodeDelegationAbstraction to avoid calling
Account.getCode()every time that we retrieve an account.Fixed Issue(s)
fixes #8392
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests