Decode deposit log data without web3j #8394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lehrner <[email protected]>
pinges
reviewed
Mar 7, 2025
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/DepositLogDecoder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
PR Overview
This pull request refactors the deposit log decoding functionality to remove the dependency on Web3J and directly decode log data using raw byte slicing. It also updates the tests to verify both correct decoding and proper error handling when given data of an incorrect length, and fully removes the DepositContract class that was previously used for decoding.
Reviewed Changes
| File | Description |
|---|---|
| ethereum/core/src/test/java/org/hyperledger/besu/ethereum/core/encoding/DepositLogDecoderTest.java | Added tests verifying the new byte slicing-based decoder and exception handling. |
| ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/DepositLogDecoder.java | Refactored the deposit log decoder to use raw byte slicing and added detailed JavaDocs. |
| ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/DepositContract.java | Removed unused code related to web3j-based deposit log decoding. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Signed-off-by: Daniel Lehrner <[email protected]>
macfarla
reviewed
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Decode the deposit log data without relying on Web3J
Fixed Issue(s)
fixes #8391
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests