Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace HttpClient with WebSocketClient in EthStatsService #8327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: replace HttpClient with WebSocketClient in EthStatsService #8327

wants to merge 2 commits into from
+20 −74

Conversation

KYash03
Copy link

@KYash03 KYash03 commented Feb 19, 2025

Fixes #8313

@KYash03 KYash03 mentioned this pull request Feb 19, 2025
Open
@macfarla
Copy link
Contributor

when I run gw compileTestJava I get this error

Execution failed for task ':ethereum:ethstats:compileTestJava'.
> Compilation failed; see the compiler output below.
  /Users/sm/workspace/b2/ethereum/ethstats/src/test/java/org/hyperledger/besu/ethstats/EthStatsServiceTest.java:219: warning: [UnusedMethod] Method 'succeededWebSocketEvent' is never used.
    private <T> AsyncResult<T> succeededWebSocketEvent(final Optional<T> object) {

Do the tests still make sense without this?

@KYash03 KYash03 force-pushed the refactor-ethstats branch 2 times, most recently from 874df2b to f9850d8 Compare February 19, 2025 05:57
@KYash03
Copy link
Author

KYash03 commented Feb 19, 2025 •
edited
Loading

I seem to have missed that. I've removed succeededWebSocketEvent.

fab-10
fab-10 reviewed Feb 25, 2025
View reviewed changes
ethereum/ethstats/src/main/java/org/hyperledger/besu/ethstats/EthStatsService.java
Comment on lines -154 to -164
private static HttpClientOptions buildHttpClientOptions(
final EthStatsConnectOptions ethStatsConnectOptions) {
final HttpClientOptions options = new HttpClientOptions();

if (ethStatsConnectOptions.getCaCert() != null) {
options.setPemTrustOptions(
new PemTrustOptions().addCertPath(ethStatsConnectOptions.getCaCert().toString()));
}
return options;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part seems not to have a replacement in the new code, are we loosing the feature to set this option?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's not needed given the transition to WebSocketClient.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please elaborate, because I do not see how it will be possible to specify a custom CA certificate with websockets. (https://besu.hyperledger.org/development/public-networks/reference/cli/options#ethstats-cacert-file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fab-10 fab-10 fab-10 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor EthStatsService creation of WebSocket
3 participants
@KYash03 @macfarla @fab-10